Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winit v0.18.1 #109

Closed
knappador opened this issue Feb 12, 2019 · 2 comments
Closed

Winit v0.18.1 #109

knappador opened this issue Feb 12, 2019 · 2 comments

Comments

@knappador
Copy link

Description

Winit minor version 0.18.1 is available

Describe your solution

I can PR the Cargo update

Are there alternatives or drawbacks?

The future leans forward

Is this a breaking change

Supposedly a minor version bump.

Additional notes

Supposedly there's a bot for generating version bump notifications
https://dependabot.com/

@knappador
Copy link
Author

https://github.com/maps4print/azul-dependencies/blob/master/glutin-0.19.0/Cargo.toml#L41

│   ├── glium v0.22.0 (https://github.com/maps4print/azul-dependencies?rev=055034bd642496cf91730a3fb4bcf3250da47772#055034bd)
│   │   ├── fnv v1.0.6 (https://github.com/maps4print/azul-dependencies?rev=055034bd642496cf91730a3fb4bcf3250da47772#055034bd)
│   │   ├── glutin v0.19.0 (https://github.com/maps4print/azul-dependencies?
...
│   │   │   ├── winit v0.18.0 (https://github.com/maps4print/azul-dependencies?rev=055034bd642496cf91730a3fb4bcf3250da47772#055034bd)

As pointed out in #57

Skip ahead to #95 for popcorn.

Closing as duplicate and shifting focus to root causes in #95

@fschutt
Copy link
Owner

fschutt commented Feb 12, 2019

Don't worry, I upgrade dependencies from time to time. But not every minor version release warrants an upgrade. Second, the forked version of winit also has some changes, mainly due to disabled unnecessary dependencies. It's not the same code as winit 0.18, it's a custom fork. So when upgrading, I need to merge over the patches / changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants