From c1f94f0d047944ea1b336ad852757a2dd4dbfc67 Mon Sep 17 00:00:00 2001 From: Luma Date: Mon, 11 Apr 2022 16:44:06 +0900 Subject: [PATCH 1/2] fix: pin react types versions `@testing-library/react` depends on `@types/react-dom@*` and yarn installs v18. It is not time to switch to v18. Then pin the versions of them. --- server/templates/@client=next/@dev-dep | 1 + server/templates/@client=next/package.json | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/server/templates/@client=next/@dev-dep b/server/templates/@client=next/@dev-dep index 6d2504f8..d0d9af30 100644 --- a/server/templates/@client=next/@dev-dep +++ b/server/templates/@client=next/@dev-dep @@ -1,5 +1,6 @@ @types/node @types/react +@types/react-dom @typescript-eslint/eslint-plugin @typescript-eslint/parser cross-env diff --git a/server/templates/@client=next/package.json b/server/templates/@client=next/package.json index 7e132466..09233208 100644 --- a/server/templates/@client=next/package.json +++ b/server/templates/@client=next/package.json @@ -32,5 +32,9 @@ "test": "jest<% } %>", "pretypecheck": "npm run generate", "typecheck": "tsc --noEmit && tsc --noEmit -p server" - } + }<% if (pm === 'yarn') { %>, + "resolutions": { + "@types/react": "^17", + "@types/react-dom": "^17" + }<% } %> } From 0dff963123a1be4950a7dbaeea21c28932605ef1 Mon Sep 17 00:00:00 2001 From: Luma Date: Mon, 11 Apr 2022 17:03:27 +0900 Subject: [PATCH 2/2] predefine @types/react-dom --- server/pretense/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/server/pretense/package.json b/server/pretense/package.json index 42c4a204..b6e27595 100644 --- a/server/pretense/package.json +++ b/server/pretense/package.json @@ -48,6 +48,7 @@ "@types/node": "^17.0.15", "@types/node-fetch": "^2.5.10", "@types/react": "^17.0.39", + "@types/react-dom": "^17.0.11", "@typescript-eslint/eslint-plugin": "^5.10.2", "@typescript-eslint/parser": "^5.10.2", "@vendia/serverless-express": "^4.5.3",