Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How is upstream integration with Gutenberg going? #4

Closed
gziolo opened this issue Aug 7, 2018 · 2 comments
Closed

How is upstream integration with Gutenberg going? #4

gziolo opened this issue Aug 7, 2018 · 2 comments

Comments

@gziolo
Copy link

gziolo commented Aug 7, 2018

Hello, I'm one of the core developers of Gutenberg. I found your repository on Twitter through this talk description: https://www.drupaleurope.org/session/introducing-gutenberg-content-editor-drupal-8.

I noticed that your latest commit pulled from upstream repository is dated July 2nd. In the meantime we reorganized the structure of the code to make it easier to use outside of WordPress. I think this will decrease the number of globals that you need to provide to make it work. We also published to npm almost all modules used in Gutenberg. You can watch progress here:
WordPress#3955
Long term, you should rather opt for consuming to those packages rather than maintaining your own fork. We are happy to discuss extensibility points which would help to make your integration easier. You can read about all documented ways you can extend Gutenberg as of today in here: https://wordpress.org/gutenberg/handbook/extensibility/.

If you have any questions or feedback to share reach out to us. You can find us on Slack in #core-editor channel on Make WordPress. Have fun integrating Gutenberg.

@SofiaSousa
Copy link
Member

Hi @gziolo,

Actually, we've been trying another approach instead of forking Wordpress/gutenberg repo because it was getting hard to maintain the code and our overrides. So, I've decided to not fork Wodpress/gutenberg repo but use it as a dependency of gutenberg-js and just maintain our overrides.

We're still using Gutenberg 3.2.0 (from #3d009d2), but I hope we can keep following the latest releases.

@gziolo
Copy link
Author

gziolo commented Aug 8, 2018

Yes, maintaining fork is super hard. This might be a better idea to use it as a dependency in the short term. However, it might not work properly with the latest version of Gutenberg because we use Lerna 3.x which works with local packages, so you might run into issues with that. When publishing to npm it is rewritten to the proper version number of each package. Anyway, you will get to it soon. Have fun and good luck. I will watch the progress in gutenberg-js repository 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants