Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elide attributes from properties that have also been reported as tag? #70

Open
frigus02 opened this issue May 9, 2024 · 0 comments
Open

Comments

@frigus02
Copy link
Owner

frigus02 commented May 9, 2024

Currently opentelemetry-application-insights reports all attributes (span and resource attributes) as properties. This means that attributes that are mapped to tags are reported twice, e.g.:

Advantages:

  • Some tags have stricter length limitations. The property could report the full value while the tag would have a shorter one.
  • Some tags are made up of multiple attributes, e.g. server.address + server.port form the Dependency Target. The properties still report the individual values.

Disadvantages:

  • Sending data twice causes more network traffic and storage. Is the amount of data relevant or small enough that it doesn't matter?

Looks like the JS exporter elides some attributes: https://github.com/Azure/azure-sdk-for-js/blob/c66cad23c4b803719db65cb48a453b0adc13307b/sdk/monitor/monitor-opentelemetry-exporter/src/utils/spanUtils.ts#L108-L143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant