Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry semantic conventions for databases are out of date #7

Closed
johnchildren opened this issue Aug 6, 2020 · 1 comment
Closed

Comments

@johnchildren
Copy link
Contributor

Hi, it looks like the opentelemetry databases semantic conventions have changed recently. Little bit annoying but easily fixable I think.

open-telemetry/opentelemetry-specification@6c86748#diff-704a6b627a90b3570049b96aac53c906

I can make a PR updating the fields that have changed if necessary, but this seems a bit annoying for users who may be using the previous conventions.

@frigus02
Copy link
Owner

frigus02 commented Aug 6, 2020

Hi John. Yeah, these changes are going to be a bit annoying for existing users of the library.

Given that the spec is still in beta, I guess those change are somehow expected. So I think I'm happy to just change this here to follow the latest spec and add some obvious breaking change note to the changelog to indicate what upgrading users will have to do.

@frigus02 frigus02 closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants