Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use per connection loggers? #57

Open
goodboy opened this issue Jan 19, 2018 · 0 comments
Open

Don't use per connection loggers? #57

goodboy opened this issue Jan 19, 2018 · 0 comments
Labels

Comments

@goodboy
Copy link
Member

goodboy commented Jan 19, 2018

The logging cookbook has a good snippet on using the extra keyword to add contextual info to output. It also suggests not using Logger instances per connection like we do.

It means changing a lot of log message calls for maybe minimal benefit unless we use a LogAdapter. I'm split on what to do since generally there's only one connection / event loop per FS process in switchio and maybe it's not worth the effort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant