Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAM support #38

Closed
willhooper opened this issue Jun 2, 2023 · 6 comments
Closed

CRAM support #38

willhooper opened this issue Jun 2, 2023 · 6 comments

Comments

@willhooper
Copy link

Hi,

Thanks for developing this great tool! It seems like nanomonsv doesn't currently support CRAM input. Would it be possible to add this? I think many would find this useful.

Thanks!
Will

@friend1ws
Copy link
Owner

Hi, thank you very much for your interest in our software.
Supporting CRAM is an option. But I'm still not sure whether people often use CRAM format for Nanopore sequence data or not so.

Supporting CRAM is technically not very challenging, But the challenge for supporting CRAM input is that we use random access in the validation phase, and the computational cost may increase significantly.
I will try to optimize Nanomonsv so that in near future we may accept CRAM format.

@willhooper
Copy link
Author

Thank you! We use CRAM for our nanopore data stored in the cloud to save on storage costs, I suspect anyone else working in the cloud would find this useful as well.

@friend1ws
Copy link
Owner

OK, I will support CRAM format and try to release it in the next version.

@friend1ws
Copy link
Owner

We have almost finished the CRAM support in the devel branch. It seems that there is not so much computational overhead because of CRAM. I will release it after additional tests hopefully next week.

@willhooper
Copy link
Author

That's great to hear. Thank you for adding this feature!

@friend1ws
Copy link
Owner

We have now pre-released the CRAM-supported version. We will provide a stable release after intensive testing. So I would like to close this issue once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants