Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [FC-118330]: Creates Id if the dropdown is created by textbox #907

Merged
merged 3 commits into from
Jan 16, 2024
Merged

fix: [FC-118330]: Creates Id if the dropdown is created by textbox #907

merged 3 commits into from
Jan 16, 2024

Conversation

prasanna-vijayan
Copy link
Collaborator

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My commits have standard messages as mentioned in Contributing Guidelines

How Has This Been Tested?

@prasanna-vijayan prasanna-vijayan changed the title fix: [FC-118330]: Creates Id if the dropdown is created by erasing textbox fix: [FC-118330]: Creates Id if the dropdown is created by textbox Jan 12, 2024
sangeet-fw
sangeet-fw approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@sangeet-fw sangeet-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvindanta arvindanta merged commit bbd072c into next Jan 16, 2024
1 check passed
@arvindanta arvindanta deleted the dependent_field_fix branch January 16, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangeet-fw sangeet-fw sangeet-fw approved these changes

@arvindanta arvindanta Awaiting requested review from arvindanta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasanna-vijayan @sangeet-fw @arvindanta