Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming #42

Closed
elijah-rappaport opened this issue Mar 25, 2022 · 4 comments
Closed

Naming #42

elijah-rappaport opened this issue Mar 25, 2022 · 4 comments

Comments

@elijah-rappaport
Copy link

There are two naming issues I've found...

NetworkingLogLevels ==> NetworkingLogLevel

HTTPVerb ==> HTTPMethod
@s4cha
Copy link
Member

s4cha commented Apr 2, 2022

@elijah-rappaport very nice catch ! Do you want to issue a PR or do you prefer I make the changes myself ?

@elijah-rappaport
Copy link
Author

@s4cha Thanks. I created a PR for these. #43
Thanks for creating this great package!

@s4cha
Copy link
Member

s4cha commented Apr 7, 2022

Thanks a ton for making it better for everyone else @elijah-rappaport. This is now live in 1.0.0 :)

@s4cha
Copy link
Member

s4cha commented Apr 15, 2022

Closing this as you solved it.

@s4cha s4cha closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s4cha @elijah-rappaport