Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird animation when the first responder is a secured textfield. #32

Closed
EfraimB opened this issue Dec 12, 2019 · 2 comments
Closed

Weird animation when the first responder is a secured textfield. #32

EfraimB opened this issue Dec 12, 2019 · 2 comments

Comments

@EfraimB
Copy link
Contributor

EfraimB commented Dec 12, 2019

Hello,

First of all congrats for the lightweight and great implementation. It's the best i've seen so far.
There is a bug where when switching the first responder from a normal textfield to a secured textfield, a weird animation is performed. This is cause because for some reason the keyboardWillChangeFrame notification is called not once but three times, the first one being a weird value. In order to fix this, we just have to perform the change animated only when the duration specified in the notification is greater than 0.

Here is a screen recording of the bug: https://my.pcloud.com/publink/show?code=XZO6ibkZ92g9nOy76gbtm7VTohGNg0GDcq27

@EfraimB
Copy link
Contributor Author

EfraimB commented Dec 12, 2019

Please merge my fix for this issue from this pull request #31
Thank you

@s4cha
Copy link
Member

s4cha commented Dec 16, 2019

This just got merged, a new release will follow. Thanks a ton for the fix !

@s4cha s4cha closed this as completed Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants