Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace print statements with loggers #81

Open
noah-kreutzer-frequenz opened this issue Feb 19, 2024 · 1 comment
Open

Replace print statements with loggers #81

noah-kreutzer-frequenz opened this issue Feb 19, 2024 · 1 comment
Assignees
@TalweSingh @noah-kreutzer-frequenz
Labels
part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users
Milestone
v1.0.0

Comments

@noah-kreutzer-frequenz
Copy link
Contributor

What's needed?

Right now some warnings are printed instead of being handled in a logger

Proposed solution

No response

Use cases

implement the warning in the loggerg

Alternatives and workarounds

No response

Additional context

No response
@noah-kreutzer-frequenz noah-kreutzer-frequenz added part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users labels Feb 19, 2024
@cwasicki cwasicki added this to the v1.0.0 milestone Sep 10, 2024
@TalweSingh TalweSingh self-assigned this Sep 23, 2024
@cwasicki
Copy link
Contributor

The print statements have been replaced by exceptions in this PR: #132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TalweSingh TalweSingh

@noah-kreutzer-frequenz noah-kreutzer-frequenz

Labels
part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@TalweSingh @noah-kreutzer-frequenz @cwasicki