Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrowParseWarnings - turning to errors in 0.15.0 #2126

Closed
xmatthias opened this issue Aug 12, 2019 · 5 comments
Closed

ArrowParseWarnings - turning to errors in 0.15.0 #2126

xmatthias opened this issue Aug 12, 2019 · 5 comments

Comments

@xmatthias
Copy link
Member

Describe your environment

  • Operating system: linux
  • Python Version: 3.7.3
  • Branch: Develop

Step 3: Related logs

site-packages/arrow/factory.py:201: ArrowParseWarning: The .get() parsing method without a format string will parse more strictly in version 0.15.0.See https://github.com/crsmithdev/arrow/issues/612 for more details.

we'll need to find all arrow.get() calls which don't use one of the supported formats (see github issue arrow-py/arrow#612) for more details.

@hroff-1902
Copy link
Member

I already grepped for it for a first glance...

@hroff-1902 hroff-1902 changed the title arrorParseWarnings - turning to errors in 0.15.0 ArrowParseWarnings - turning to errors in 0.15.0 Aug 12, 2019
@xmatthias
Copy link
Member Author

xmatthias commented Aug 13, 2019

seems like the warnings will stay for all string-parsing, no matter if it's supported in 0.15.0 or not (so it's not showing us where we're doing something non-supported)

Parsing integers (like arrow.get(since_ms // 1000)) will however continue to work, so i think the imact to freqtrade is very limited, if it impacts us at all.

Also all supported date-formats remain there (and we don't use anything exotic afaik) - so i'm not sure if we need to act. We'll however need to do testing once 0.15.0 hits.

@hroff-1902
Copy link
Member

arrow.get(starts, 'YYYYMMDD')

in freqtrade.configuration.arguments.Arguments.parse_timerange() will also be supported...

@hroff-1902
Copy link
Member

Have not found any suspicious yet. (grepped for import|from Arrow|arrow, Arrow|arrow)

I wanted to post here the whole list of appearances where arrow.get() is used in the current codebase for review, but a bit lazy for this...

@xmatthias
Copy link
Member Author

This has now landed - and i ran through all modes we have and didn't find any issues, so i'll close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants