Skip to content

Migrate from backoff to python-backoff#2060

Merged
frenck merged 2 commits into
frenck:mainfrom
mik-laj:backoff
May 20, 2026
Merged

Migrate from backoff to python-backoff#2060
frenck merged 2 commits into
frenck:mainfrom
mik-laj:backoff

Conversation

@mik-laj
Copy link
Copy Markdown
Collaborator

@mik-laj mik-laj commented May 10, 2026

Proposed Changes

For justifications, see: home-assistant/core#170242

(Describe the changes and rationale behind them)

Related Issues

(GitHub link to related issues or pull requests)

Summary by CodeRabbit

  • Chores
    • Updated a dependency to a newer version.

Review Change Stack

Copilot AI review requested due to automatic review settings May 10, 2026 01:15
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 10, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d7df4697-8977-4a44-a33b-a299b6d41715

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The project dependency list is updated to replace the backoff library with python-backoff and bump the minimum version constraint from 2.2.0 to 2.3.1.

Changes

Dependency Update

Layer / File(s) Summary
Backoff Library Upgrade
pyproject.toml
The backoff library dependency is replaced with python-backoff (>=2.3.1), updating from the prior backoff (>=2.2.0) requirement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a skip, a package swap,
From backoff old to new python-backoff top,
Version 2.3.1, we retry with glee,
Dependency trees bloom fresh and free! 🌱✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Migrate from backoff to python-backoff' accurately and concisely describes the main change: replacing the backoff dependency with python-backoff as shown in pyproject.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s retry/backoff dependency from backoff to the python-backoff distribution, aligning this library with the dependency migration referenced from Home Assistant Core.

Changes:

  • Replace the runtime dependency backoff (>=2.2.0) with python-backoff (>=2.3.1) in pyproject.toml.
  • Regenerate poetry.lock to drop backoff and add python-backoff, along with associated lock metadata updates.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Swaps the project dependency from backoff to python-backoff.
poetry.lock Removes backoff and adds python-backoff (and refreshes lock metadata).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mik-laj mik-laj added the dependencies Upgrade or downgrade of project dependencies. label May 10, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.29%. Comparing base (3e87d76) to head (01b3023).
⚠️ Report is 604 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2060       +/-   ##
===========================================
+ Coverage   58.61%   97.29%   +38.68%     
===========================================
  Files           6        8        +2     
  Lines         662     1108      +446     
  Branches      143      112       -31     
===========================================
+ Hits          388     1078      +690     
+ Misses        270       20      -250     
- Partials        4       10        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mik-laj mik-laj marked this pull request as ready for review May 11, 2026 19:06
Copy link
Copy Markdown
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Backoff might not be the path forward maybe... but this will close the raised gap for now for sure!

Thanks @mik-laj!

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit f168b05 into frenck:main May 20, 2026
18 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Upgrade or downgrade of project dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants