Migrate from backoff to python-backoff#2060
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe project dependency list is updated to replace the ChangesDependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the project’s retry/backoff dependency from backoff to the python-backoff distribution, aligning this library with the dependency migration referenced from Home Assistant Core.
Changes:
- Replace the runtime dependency
backoff (>=2.2.0)withpython-backoff (>=2.3.1)inpyproject.toml. - Regenerate
poetry.lockto dropbackoffand addpython-backoff, along with associated lock metadata updates.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pyproject.toml |
Swaps the project dependency from backoff to python-backoff. |
poetry.lock |
Removes backoff and adds python-backoff (and refreshes lock metadata). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
===========================================
+ Coverage 58.61% 97.29% +38.68%
===========================================
Files 6 8 +2
Lines 662 1108 +446
Branches 143 112 -31
===========================================
+ Hits 388 1078 +690
+ Misses 270 20 -250
- Partials 4 10 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frenck
left a comment
There was a problem hiding this comment.
👍
Backoff might not be the path forward maybe... but this will close the raised gap for now for sure!
Thanks @mik-laj!
../Frenck
Blogging my personal ramblings at frenck.dev
Proposed Changes
For justifications, see: home-assistant/core#170242
Related Issues
Summary by CodeRabbit