[v2023.1.x] gluon-core: dont fail on unset interface role #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case no interface role was selected for a given interface, gluon-reconfigure currently fails with Configuring: 021-interface-roles /usr/bin/lua: /usr/lib/lua/gluon/util.lua:25: bad argument #1 to 'pairs' (table expected, got nil) stack traceback: [C]: in function '?' /usr/lib/lua/simple-uci.lua:22: in function 'foreach' ./021-interface-roles:47: in main chunk [C]: ? Check we actually have a role set before accessing the table. Signed-off-by: David Bauer <[email protected]> (cherry picked from commit c4d3703)
rotanid
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case no interface role was selected for a given interface, gluon-reconfigure currently fails with
Check we actually have a role set before accessing the table.
Signed-off-by: David Bauer [email protected]
(cherry picked from commit c4d3703)
Backport of #3050
Haven't tested it (yet). Will do that once Github has created some images. But i don't expect issues.