Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tunneldigger dies somtimes #1188

Closed
Sunz3r opened this issue Jul 11, 2017 · 9 comments
Closed

tunneldigger dies somtimes #1188

Sunz3r opened this issue Jul 11, 2017 · 9 comments
Labels
9. meta: upstream issue Issue pertains to an upstream project

Comments

@Sunz3r
Copy link
Contributor

Sunz3r commented Jul 11, 2017

If internet lost connection (like reboot of router or plug off lan-cable) then the tunneldigger sometime dies.

After strace the tunneldigger i found that a assert is triggered: https://github.com/wlanslovenija/tunneldigger/blob/master/client/asyncns.c#L884

https://pastebin.com/R6CQmGXr

@neocturne
Copy link
Member

The right place to report this is the Tunneldigger bug tracker at https://dev.wlan-si.net/report/15. I'll still keep this ticket open to track it for Gluon.

@mitar
Copy link

mitar commented Jul 13, 2017

cc @kostko

@Sunz3r
Copy link
Contributor Author

Sunz3r commented Jul 19, 2017

I was not able to report this bug on there site ...

this bug happens when dns-resolution failed and despite sending data through a socket:
td-client: Failed to send() control packet (errno=89, type=1)!
when dns-resolution suddenly works in this situation then the tunneldigger will crash.

I think there is a bug in the broker selection. The selector should wait for successful address-resolution.

To workaround this bug you can use ip's instead of names.

@Adorfer
Copy link
Contributor

Adorfer commented Jul 19, 2017

To workaround this bug you can use ip's instead of names.

thanks for the hint.
perhaps add a note in the site.conf example.doc in case of tunneldigger/l2tp use.

@mitar
Copy link

mitar commented Jul 19, 2017

Interesting. We always use IPs, so this is why we didn't notice this before.

@rotanid rotanid added the 9. meta: upstream issue Issue pertains to an upstream project label Oct 13, 2017
@ghost
Copy link

ghost commented Nov 20, 2017

@mitar: How can i report bugs at https://dev.wlan-si.net/newticket?component=tunneldigger ? The registration link automatically moves me to the wlan-slovenia registration but the created account doesn't work on dev.wlan-si.net. And without an account, I will only see the message "TICKET_CREATE privileges are required to perform this operation"

Btw. the bug I see is with newer kernels (

Only one session (tunnel interface) can be created. All other sessions create a "Failed to setup tunnel with id 102!".

The test kernel is linux-image-4.9.0-4-amd64. And I saw some changes which might be related:

- l2tp: fix race in l2tp_recv_common()
- l2tp: ensure session can't get removed during pppol2tp_session_ioctl()
- l2tp: fix duplicate session creation
- l2tp: hold session while sending creation notifications
- l2tp: take a reference on sessions used in genetlink handlers

@kostko
Copy link

kostko commented Nov 20, 2017

Report them in the GitHub repository.

@kostko
Copy link

kostko commented Nov 20, 2017

BTW, there is already a fix for the session ID issue you mention. It is in wlanslovenija/tunneldigger#64 (not yet merged into master).

@rotanid
Copy link
Member

rotanid commented Jan 10, 2018

we will close this issue here, as tunneldigger has recently been updated to the latest version.
you may continue to use this for discussion, but it should rather take place upstream.

@rotanid rotanid closed this as completed Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9. meta: upstream issue Issue pertains to an upstream project
Projects
None yet
Development

No branches or pull requests

6 participants