Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile the performance of the ES response-serialization API and the frontend template-rendering code. #4708

Open
albertisfu opened this issue Nov 19, 2024 · 0 comments

Comments

@albertisfu
Copy link
Contributor

A user pointed out that our ES results serialization for rendering API requests might be slower than necessary because it involves converting dictionaries to Python objects in the DRF serializer and then back to dictionaries when sending data to the client.
This process could be slower than avoiding the conversion to Python objects by using custom code for our serializer.
Therefore, we should profile the performance of this related code to compare both approaches.

Additionally, we could further analyze the issue by considering that the ES response is already a Python object based on a custom AttrDict class. It might be possible to eliminate the Python objects earlier in the process and use dictionaries downstream if this improves performance and simplifies the code.

@mlissner mlissner added this to Sprint Nov 19, 2024
@mlissner mlissner moved this to Backlog Nov 25 - Dec 6 in Sprint Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog Dec 23 - Jan 3 (🔍)
Development

No branches or pull requests

1 participant