Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish dbgsym packages #7347

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Publish dbgsym packages #7347

merged 1 commit into from
Nov 26, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Nov 22, 2024

Status

Ready for review

Description of Changes

For various reasons, Ubuntu names these with a ddeb file extension so our wildcard for *.deb wasn't catching them. So let's collect them but also rename them to use the standard deb extension.

Testing

How should the reviewer test this PR?

  • Run make build-debs and see that you (now) get a securedrop-app-code dbgsym package.

Deployment

Any special considerations for deployment? n/a

Checklist

  • I have written a test plan and validated it for this PR

For various reasons, Ubuntu names these with a `ddeb` file extension
so our wildcard for `*.deb` wasn't catching them. So let's collect
them but also rename them to use the standard `deb` extension.
Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • visual review
  • ci
  • make build-debs builds a securedrop-app-code dbgsym package
    thanks @legoktm :)

@rocodes rocodes added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit b7bda4f Nov 26, 2024
44 checks passed
@legoktm legoktm deleted the pub-dbgsym branch January 9, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants