Prevent IntegrityError on repeated reset of journalist password #5618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5617.
Instead of breaking down and making everyone uncomfortable when encountering
IntegrityError
while revoking a journalist's two-factor token during a password reset, roll with it, take it in stride, demonstrating resilience, class, even aplomb.Testing
Follow the STR in #5617 on
develop
. Thengit checkout -b fix-5617 origin/fix-5617
and repeat. You should now be able to reset a password for the rest of your days error-free, if that seems a good alternative to whatever else 2020 is handing you.Deployment
It's probably fine. It's better than it was, anyway. With the new error handling in place, the admin doesn't encounter an error, the journalist gets a new password, everyone's happy.
Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development containerIf you made non-trivial code changes:
Choose one of the following: