Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut 1.5.0 rc2 #5389

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Cut 1.5.0 rc2 #5389

merged 4 commits into from
Jul 20, 2020

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Jul 20, 2020

Status

Status

Ready for review

Description of Changes

Cherry picks onion service terminology changes and deprecation warnings from #5373 and #5379 to the 1.5.0 release branch. Updates version and changelog.

Testing

Confirm that the changes match #5373 and #5379.

Deployment

This is mostly terminology changes in docs and comments, with one string change to the deprecation warning shown in the journalist interface.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

- "Hidden Services" begone, retire "ATHS" abbreviation
- Lower case throughout except in titles, per typical
  Tor project usage
- Retire "ATHS" abbreviation
- Address https://github.com/freedomofpress/securedrop/pull/5373/files#r454731330
- Whitespace fixes

(cherry picked from commit 5b50c7c)
Remove outdated Tails version guidance

Better link for onion auth info

(cherry picked from commit 54af899)
@rmol rmol changed the base branch from develop to release/1.5.0 July 20, 2020 19:47
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rmol , good to merge when CI passes

@rmol rmol mentioned this pull request Jul 20, 2020
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog lgtm!

@rmol rmol merged commit 79ccffc into release/1.5.0 Jul 20, 2020
@rmol rmol deleted the cut-1.5.0-rc2 branch July 20, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants