Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecureDrop 1.5.0~rc2 #5383

Closed
wants to merge 1 commit into from
Closed

SecureDrop 1.5.0~rc2 #5383

wants to merge 1 commit into from

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Jul 16, 2020

Status

Ready for review

Description of Changes

Adds #5380 (more prevention of giving journalists a username of "deleted") for rc2.

emkll
emkll previously approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmol , changelog updates LGTM. Good to merge when CI passes.

@emkll emkll dismissed their stale review July 16, 2020 17:50

As discussed in standup today, we will be merging some changes around onion service language and address community string feedback before cutting rc2

@rmol
Copy link
Contributor Author

rmol commented Jul 20, 2020

Closing in favor of #5389.

@rmol rmol closed this Jul 20, 2020
@rmol rmol deleted the make-1.5.0-rc2 branch July 20, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emkll emkll emkll left review comments

@conorsch conorsch Awaiting requested review from conorsch

@kushaldas kushaldas Awaiting requested review from kushaldas

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmol @emkll