Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 deprecation timeline & warnings to docs #5373

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Jul 14, 2020

Status

Ready for review

Descriptions

Adds docs consistent with #5366. Includes whitespace fixes. Note that this is the page of the documentation https://securedrop.org/v2-onion-eol currently redirects to.

Checklint

  • Linter is surprised by how clean and elegant this change is ✨

There is no downgrade path from v3 to v2 using the ``securedrop-admin``
tool. We recommend that you follow the v2+v3 migration path below, and test v3
functionality thoroughly before disabling
v2 services.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you link "disabling v2 services" to a section in the doc that says how to do this? right now we just have a section on how to enable v3 onion service which somewhere in the middle says:

Next, enable v3 onion services (and optionally disable v2 services) using:
./securedrop-admin sdconfig

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @creviera, addressed as part of #5379.

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zenmonkeykstop zenmonkeykstop merged commit 6fb5a94 into develop Jul 15, 2020
@rmol rmol mentioned this pull request Jul 20, 2020
4 tasks
@legoktm legoktm deleted the docs-onion-deprecation branch January 9, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants