Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated qubes staging vm names to avoid conflict with workstation vms #5099

Merged

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #5097.

Updates docs and molecule scenario to change Qubes staging VM names, to avoid a conflict with names in use by the SecureDrop Workstation.

Testing

(In Qubes....)

  • Remove previous Qubes staging and staging base VMs
  • check out this branch
  • follow the documentation to provision a staging environment - the process is a success.

Deployment

Dev-only change, affecting SD core development on Qubes.

Checklist

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@eloquence
Copy link
Member

LGTM based on visual review, but needs a full test run.

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on visual review.

@conorsch conorsch merged commit 28b1176 into freedomofpress:develop Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Qubes staging standalone VM due to conflict with workstation VM
3 participants