Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UA regex to match TB9 user agent strings #5087

Merged
merged 1 commit into from
Jan 7, 2020
+5 −4
Merged

Update UA regex to match TB9 user agent strings #5087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions securedrop/static/js/source.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const TBB_UA_REGEX = /Mozilla\/5\.0 \((Windows NT 6\.1|X11; Linux x86_64|Macintosh; Intel Mac OS X 10\.13|Windows NT 6\.1; Win64; x64); rv:[0-9]{2}\.0\) Gecko\/20100101 Firefox\/([0-9]{2})\.0/;
const TBB_UA_REGEX = /Mozilla\/5\.0 \((Windows NT 10\.0|X11; Linux x86_64|Macintosh; Intel Mac OS X 10\.14|Windows NT 10\.0; Win64; x64); rv:[0-9]{2}\.0\) Gecko\/20100101 Firefox\/([0-9]{2})\.0/;
const ORFOX_UA_REGEX = /Mozilla\/5\.0 \(Android; Mobile; rv:[0-9]{2}\.0\) Gecko\/20100101 Firefox\/([0-9]{2})\.0/;

function fadeIn(el, duration = 200, displayStyle = "block") {
Expand Down Expand Up @@ -64,8 +64,9 @@ function addFadingClose(id, elementToClose, fadeDuration = 200) {

/**
Tor Browser always reports a UTC timezone and window dimensions
that match the device dimensions, which is very unlikely in desktop
browsers.
that match the device dimensions. This is unlikely in desktop
browsers unless they implement anti-fingerprinting techniques
(such as Firefox privacy.resistFingerprinting).
*/
function looksLikeTorBrowser() {
return window.navigator.userAgent.match(TBB_UA_REGEX) &&
Expand All @@ -87,7 +88,7 @@ function looksLikeOrfox() {
*/
function showTorSuggestions() {
show("#js-warning");

let infoBubble = document.getElementById("security-setting-info");

// show the instruction popup when the link is clicked
Expand Down