Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n.json is used in app startup but not included in apache2 apparmor config. #7450

Open
zenmonkeykstop opened this issue Feb 27, 2025 · 1 comment · May be fixed by #7451
Open

i18n.json is used in app startup but not included in apache2 apparmor config. #7450

zenmonkeykstop opened this issue Feb 27, 2025 · 1 comment · May be fixed by #7451
Assignees
@cfm
Labels
QA: Release release blocker

Comments

@zenmonkeykstop
Copy link
Contributor

i18n.json is now being used during app setup to determine which locales are valid. It needs to be included in Apparmor for apache2 (with read perms) to support this in production and staging environments. Otherwise app startup fails and interfaces return a 500 error.

Expected behavior

App setup completes in prod

Actual behavior

App setup fails, with file access errors for the aforementioned file.
@cfm cfm linked a pull request Feb 27, 2025 that will close this issue
Open
2 tasks
@cfm
Copy link
Member

cfm commented Feb 27, 2025

Why didn't we catch this in review of #7443?

  1. It's an AppArmor failure, which don't manifest under make dev.
  2. i18n.json isn't a new file; it's been installed at least since https://github.com/freedomofpress/securedrop/blame/151c66c210e8e2653f34506a4627d23d9ab20b8b/securedrop/debian/securedrop-app-code.install#L6 and (since that's a blame-breaking refactor) likely earlier. We're just reading it in the Flask apps under Apache for the first time.
  3. We should have spotted this on develop, e.g. in https://github.com/freedomofpress/securedrop/actions/runs/13509708155/job/37747256075#step:3:39633....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfm cfm

Labels
QA: Release release blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow Apache to read i18n.json freedomofpress/securedrop
2 participants
@cfm @zenmonkeykstop