Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

securedrop-admin sdconfig is allowing journalist notification email address without gpg key #3320

Closed
kushaldas opened this issue Apr 28, 2018 · 1 comment
Assignees
Milestone

Comments

@kushaldas
Copy link
Contributor

Bug

Description

./securedrop-admin sdconfig allows to put a journalist notification email address without mentioning any journalist GPG key file, or the fingerprint.

Steps to Reproduce

./securedrop-admin sdconfig

Expected Behavior

If the journalist notification GPG key is not given, then it should skip next two questions.

Actual Behavior

It allows the admin to add a journalist notification email address.

Local filepath to journalist alerts GPG public key (optional): 
Full fingerprint for the journalist alerts GPG public key (optional): 
Email address for receiving journalist alerts (optional): *******@gmail.com
@ghost
Copy link

ghost commented Apr 28, 2018

The sdconfig implementation unfortunately does not allow for contextual behavior. It should be improved to go beyond asking a set of questions and select which questions should be asked depending on the previous answers.

I tend to agree this is a usability bug although it could be seen as a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants