Updates VM tests for 2021 key expiry #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the old signing key has expired, the message has changed somewhat: "expires" -> "expired". Also fixed an outdated dnf check to expect the gpg verification output.
conorsch
force-pushed
the
keyring-2021-tests
branch
from
8d10fdc to
9d47570
Compare
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Now that the old signing key has expired, the message has changed somewhat: "expires" -> "expired". Also fixed an outdated dnf check to expect the gpg verification output. I updated the logic in the tests to be a bit friendlier to edit over time, such as using a multiline string rather than a list of stdout lines.
Addresses the final checkbox for fixing the tests in freedomofpress/qubes-template-securedrop-workstation#20
Testing
All tests should be passing. If you haven't run the updater recently, you may see some failed tests due to uninstalled nightlies. Apply those changes, and make sure you see 100% of tests passing.
Deployment
None, test-only.