Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not explicitly install qubes-template-whonix-ws/gw-14 #289

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Jul 16, 2019

Fixes #287

Since Qubes 4.0.1 isos include these templates. The templates cannot be downloaded via qubes-dom0-upgrade so fail on clean install.

Since Qubes 4.0.1 isos include these templates. The templates cannot be downloaded via qubes-dom0-upgrade so fail on clean install.
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test:

  1. Checkout your branch in sd-dev
  2. make clone in the securedrop-workstation directory in dom0 (and verified the changes from your branch were copied over)
  3. make clean
  4. make all

I get the same errors about the missing packages

@sssoleileraaa
Copy link
Contributor

more info about my system:

  • /etc/os-release says version 4.0 (R4.0)
  • uname -r says 4.14.119-2.pvops.qubes.x86_64

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the same test with the latest commit and...

🌟 🌟 🌟 🌟 🌟 🌟

🌟 IT WORKS!!! 🌟

🌟 🌟 🌟 🌟 🌟 🌟

shipit

@sssoleileraaa
Copy link
Contributor

Resolves #284

@rmol
Copy link
Contributor

rmol commented Jul 17, 2019

Can also confirm this solves the problem.

@emkll
Copy link
Contributor Author

emkll commented Jul 17, 2019

thanks for reviewing @creviera @rmol !

@emkll emkll merged commit dff840b into master Jul 17, 2019
@emkll emkll deleted the 287-use-iso-whonix-templates branch July 17, 2019 17:09
@rmol rmol mentioned this pull request Jul 17, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make all errors
3 participants