Install evince in sd-svs-disp-template #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After cherry-picking the fixes from #289 (this will need a rebase) the test plan succeeded, and ultimately a PDF was opened with evince. |
Minimal debian-9 install in securedrop-workstation template no longer contains evince. It is required to open PDF files.
emkll
force-pushed
the
sd-svs-disp-install-evince
branch
from
9b4bd53 to
ce2bebd
Compare
|
rebased on latest |
|
The PR looks okay. My |
|
@kushaldas is your sys-whonix VM connected to Tor? There's a whonixcheck script you can use in that VM |
conorsch
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282
Test plan:
make cleanmake allmake testall tests pass