Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds apache and 2600 #39

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Adds apache and 2600 #39

merged 1 commit into from
Mar 4, 2021

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Mar 4, 2021

Status

Ready for review

Fixes #37
Fixes #38

Review Checklist

  • Changes to onboarded.txt are accurate
  • The file default.rulesets.TIMESTAMP.gz has been updated, extracting that file and inspecting the contents of the JSON file produces the expected rules
  • The ruleset has been verified by modifying the HTTPS Everywhere configuration in a Tor Browser instance pointing to Path Prefix: https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAME
  • index.html has been updated using ./update_index.sh

Post-Deployment Checklist

  • Added/modified onion names have been updated in the SecureDrop Directory

@eloquence eloquence self-assigned this Mar 4, 2021
@conorsch
Copy link
Contributor

conorsch commented Mar 4, 2021

Haven't reviewed yet, post-merge, please monitor for updates to the prod endpoint. They should happen automatically. There may still be a caching delay, but @maeve-fpf (or I) can bust the cache at a moment's notice. I'm more interest in confirming that the automatic updates to the rulesets are deployed upon merge into the main branch here.

Copy link
Member

@eloquence eloquence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ticked boxes in in PR body.

@eloquence eloquence merged commit 1b51226 into main Mar 4, 2021
@conorsch
Copy link
Contributor

conorsch commented Mar 4, 2021

please monitor for updates to the prod endpoint

$ curl -s https://securedrop.org/https-everywhere/latest-rulesets-timestamp 
1614864041

Looks good! Matches the changes presented here.

@eloquence
Copy link
Member

I'm having difficulty getting Tor Browser to actually fetch the updated rules. Even when Update last checked (in the HTTPSE extension preferences -> Update channels) is just a minute ago, the SecureDrop ruleset is stuck at 2021.2.5. Auto-update is enabled. I've tried in Tails and using a separate Tor Browser instance on Ubuntu.

curling the resources at first glance everything looks good, so I'm not sure what's going wrong here. Could you see if you can reproduce?

@conorsch
Copy link
Contributor

conorsch commented Mar 4, 2021

Could indeed reproduce! curl was showing me the latest, but Tor Browser wasn't. That endpoint is heavily cached because it gets a few million hits a day, so I busted the cache manually. After some fussing with Tor Browser where it wouldn't respond to the "Update channel" button in the HTTPSE extension settings, I restarted Tor Browser, and it worked just fine.

So we still need to wire up some automatic cache busting for these changes, but can confirm that the logic was at least deployed. Cache would have expired in ~2h, but we can make it automatic on changes, too.

@eloquence
Copy link
Member

Confirmed working for me now as well; updated directory entries with onion names. 🎉

@maeve-fpf maeve-fpf deleted the 37-38-apache-2600 branch August 19, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add onion name for 2600.com Add onion name for Apache.be
3 participants