Install apparmor profiles in sd-svs-disp #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure upstream apparmor profiles are installed and enforced. This includes profiles for: * libreoffice * totem * evince
emkll
changed the title
kushaldas
approved these changes
Jan 3, 2020
There was a problem hiding this comment.
Tested as
- package successfully builds (
PKG_VERSION=0.1.4 make securedrop-workstation-svs-disp) - move package to sd-svs-disp-buster-template and install package in that template (
sudo apt-get -f install to resolve dependencies) - package installs successfully,
sudo aa-statusshows profiles - in sd-svs-disp, open a pdf in evince
- evince apparmor profile is enforced for the process (when evince is open,
sudo aa-status)
Works as suggested, the PR is good visually too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes freedomofpress/securedrop-workstation#384
This will ensure upstream apparmor profiles are installed and enforced. This includes profiles for:
It appears that in compat level 10 (default for buster), files are not copied to /etc . Since we want to automatically squash the paxctld configuration, let's move it to
/optand move in place to/etcin postinst.Test plan
PKG_VERSION=0.1.4 make securedrop-workstation-svs-disp)sudo apt-get -f install to resolve dependencies)sudo aa-statusshows profilessudo aa-status)