Action menu item (Delete) "Files and messages" remain active after deletion

[gonzalo-bulnes]

Description

When deleting all "Files and messages" in a conversation, the UI doesn't provide expected feedback.

Steps to Reproduce

1. Select a source with messages, files or replies
2. Trigger the (Delete) "Files and messages" item in the actions menu

Expected Behavior

The menu entry is disabled after the operation is complete (because there is nothing else to delete).

Actual Behavior

The menu entry remain active, and can be triggered. Triggering it again is not useful (the dialog goes on to warn that you'll delete 0 files, 0 replies, 0 messages, etc.) and is a lost opportunity for timely feedback.

Comments

The state of another menu entry in the same menu (Download) "All Files" is handled based on information provided by state.State. The same could be done here. That would be a good opportunity to make the application state.State aware of messages and replies. See #1388 and #1448 (which prepared the DeleteConversationAction in view of fixing this issue).

CC; @tina-ux

[gonzalo-bulnes]

I noticed this 🐞 again today when pairing with @tina-ux.