Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "download all files" after files have been deleted #1442

Closed
sssoleileraaa opened this issue Mar 15, 2022 · 3 comments · Fixed by #1448
Closed

Disable "download all files" after files have been deleted #1442

sssoleileraaa opened this issue Mar 15, 2022 · 3 comments · Fixed by #1448
Assignees

Comments

@sssoleileraaa
Copy link
Contributor

STR

  1. Select a source with files that have not yet been downloaded
  2. Delete the source conversation
  3. Select the source menu

Expected

The "download all files" option to be disabled, since there are no longer files to download.

Actual

The "download all files" option is enabled, and if you select it then you get an error message in the status bar that the file could not be downloaded.

@sssoleileraaa
Copy link
Contributor Author

@gonzalo-bulnes this is a followup issue for #1388

@gonzalo-bulnes
Copy link
Contributor

For coordination: I'm looking into it.

@gonzalo-bulnes
Copy link
Contributor

gonzalo-bulnes commented Mar 16, 2022

Reproduced the described behavior by following the STR 🍏

👉 Action plan:

👓 Longer term vision: this continues establishing a pattern where the updates of state.State that are caused by user actions will be triggered from the collection of Qt actions. Those updates are triggered along with the controller commands for now, until we start triggering the controller commands automatically when the state changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants