Adds wheels for requests 2.22.0, urllib3-1.25.10 #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkll
suggested changes
Oct 8, 2020
There was a problem hiding this comment.
- diff review for urllib3 1.25.10 : https://github.com/freedomofpress/securedrop-debian-packaging/wiki/urllib3-1.25.8-to-1.25.10
- diff review for requests is : https://github.com/freedomofpress/securedrop-debian-packaging/wiki/Requests-2.20.0-to-2.22.0
Two things prior to merge:
- Could you please upload the build logs of the wheels to https://github.com/freedomofpress/build-logs/tree/main/pip_mirror
- The URLs in the html files for the respective dependencies needs to be updated, you can see an example here https://github.com/freedomofpress/securedrop-debian-packaging/pull/137/files#diff-c89b85e34e3f449bb8a7cea42b327f11R12-R13 , for now a manual step, see Further automate html generation with updateindex.py #200
3 tasks
|
Closing this in favor of #201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
securedrop-proxyandsecuredrop-clienthave updated build requirements for:urllib3, from 1.25.8 to 1.25.10requests, from 2.20.0 to 2.22.0This PR includes updated wheels for said versions.