Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: Update our macOS entitlements #639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

apyrgio
Copy link
Contributor

@apyrgio apyrgio commented Dec 6, 2023

Our entitlements were last updated when Dangerzone was considering using HyperKit to spawn VMs (9158d02, on 2021-06-30). Now that we use Docker Desktop, we can make them stricter.

Fixes #638

Our entitlements were last updated when Dangerzone was considering
using HyperKit to spawn VMs (9158d02, on 2021-06-30). Now that we use
Docker Desktop, we can make them stricter.

Fixes #638
Copy link
Contributor

@deeplow deeplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this is not working. Reverting my review.

@apyrgio
Copy link
Contributor Author

apyrgio commented Jan 30, 2024

This PR is blocked because the suggested entitlements break mounting files in the container. This will have to wait until we resolve #625, in which case, we will pass files via the container's standard streams.

@apyrgio apyrgio added this to the 0.7.0 milestone Jun 3, 2024
@almet almet removed this from the 0.7.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make our macOS entitlements stricter
3 participants