-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistently on convert, invalid json returned from container
#371
Comments
invalid json returned from container
invalid json returned from container
A user had reported a similar issue a few months ago: #253 Could you run the following commands, to make sure that Docker works properly?
|
Thanks for the suggestion.
One difference against past issue. The line I recall coming across #253 in earlier troubleshooting. But couldn't get dangerzone in command line, then abandoned that line of debugging. |
Thanks for the command output. So, Docker seems to be working correctly. Next thing we should check is what is the message that the container throws. I'm not that well-versed on MacOS, so I don't know where the standard streams are redirected, when you double click on the command. However, you should be able to run Dangerzone from the terminal, and you should find more info there. Run the following for the Dangerzone application:
Or the following for the Dangerzone CLI:
|
Thanks for including MacOS-specific instructions to dig out further information. stepsrun: resultI get the following output from the CLI: CLI output from running Dangerzone CLI against test.pdf
findings
|
Nice, thanks a lot for the container output! It's interesting, we have not seen it before. This error seems to be related to some permission-related changes on Big Sur: https://apple.stackexchange.com/questions/425519/why-do-i-get-ls-desktop-operation-not-permitted-when-i-own-desktop Thanks also for the output of
We can try to reproduce this issue based on the above info. Then, we can verify if this will be fixed in 0.4.1. In the meantime, you can try it out yourself, following our build instructions for MacOS minus the Homebrew and app bundle stuff. |
1 similar comment
Nice, thanks a lot for the container output! It's interesting, we have not seen it before. This error seems to be related to some permission-related changes on Big Sur: https://apple.stackexchange.com/questions/425519/why-do-i-get-ls-desktop-operation-not-permitted-when-i-own-desktop Thanks also for the output of
We can try to reproduce this issue based on the above info. Then, we can verify if this will be fixed in 0.4.1. In the meantime, you can try it out yourself, following our build instructions for MacOS minus the Homebrew and app bundle stuff. |
(duplicate message due to some GitHub UI issues) |
Thanks for including the resource on permission changes starting from Big Sur! Below, items 1 through 3 are related to prompts from #371 (comment). 4 and 5 are additional.
CLI output from running Dangerzone CLI against test.pdf with Full Disk Access granted to Docker
|
Yay! But also, damn. It worries me that more and more users will start stumbling on this issue, and these users will not be tech-savvy :-/. Ultimately, that is a Docker Desktop problem, so hopefully they will offer a fix as part of the installation. Else, any
To the best of my knowledge, no. Funny thing though is that at the same time you posted this issue, another user posted a problem related to Docker not being found: #374. They resolved it in a brute kind of way, but maybe something in this thread helps you understand what's going on. |
Further finding on minimum permissions required: FWIW it's enough to give Docker access to only the directory containing the intended file(s) to be converted. Full Disk is unnecessary.
Thanks for linking to a relevant conversation. To avoid cluttering this thread with a likely unrelated problem, I'll tackle it separately.
My research shows that apps which depend on similar permissions, to operate as expected, display a modal to inform users about the suggested settings. They may also choose to include a button that surfaces the relevant view in System Settings, for Privacy & Security. Is something similar useful/actionable enough for users here? |
Nice, highlighting the important part so that other users notice it as well. As for showing a modal to the user for System Integrity Protection (SIP): I would expect that this is something that Docker Desktop would have to do, whenever it detected that a user wants to mount a path that it doesn't have permissions for. I'm afraid I don't see how Dangerzone can trigger such a modal for Docker, given that |
Regardless of what Dangerzone can do in subsequent versions, let's settle on some next steps to resolve this issue. My suggestion is to add a note about this error on our README ("I get |
A workaround to an issue related to SIP imposed on Docker has been identified in freedomofpress#371. Update README.md to include friendly instructions for MacOS 11+ users blocked by this issue.
A workaround to an issue related to SIP imposed on Docker has been identified in freedomofpress#371. Update README.md to include friendly instructions for MacOS 11+ users blocked by this issue.
On attempting to convert one or more files, error of
invalid json returned from container
. This happens consistently, and no files are converted successfully.versions
reproduce
other context
This issue is a change from long-time use, where conversion was working. This error began on 2023.02.06. The first indication of something being broken was Dangerzone failing to detect Docker.
I removed both, and reinstalled. This resolved Dangerzone not detecting Docker. Then
invalid json returned from container
began appearing.Removing, and reinstalling has no further effect.
The text was updated successfully, but these errors were encountered: