-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add first lab for OOP in frontend cert #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments 👍
@@ -0,0 +1,25 @@ | |||
You should define a constant of type ENUM named `projectStatus` with the different project statuses you want to have such as `PENDING`, `SUCCESS`, or `FAILURE` with ypur preferred descriptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the concept of ENUM hasn't really be explained at this point.
that won't really happen until the typescript section.
so this will need to be reworded to just have them create the object with the properties and value you want them to create
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use plain objects instead of frozen ones.
|
||
You should `unpin` random instances of the `ProjecIdea` class from their respective boards. | ||
|
||
You should examine the boards before and after pinning and unpinning of new project ideas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what this last user story means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed these two. I think they are not that important.
@jdwilkin4 ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment for the first user story 👍
Otherwise, everything else looks good
@@ -0,0 +1,19 @@ | |||
You should define a constant of type `Object` named `projectStatus` with the different project statuses you want to have such as `PENDING`, `SUCCESS`, or `FAILURE` with your preferred descriptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the sheet, Object
seems to only come up once in the lecture videos.
So not too many campers will feel comfortable using the Object type.
They will probably feel more comfortable doing something like this
const projectStatus = {
PENDING: { description: "Pending Execution" },
SUCCESS: { description: "Executed Successfully" },
FAILURE: { description: "Execution Failed" },
};
while your solution is still valid, not to many campers are going to instinctively reach for the Object
type and Symbol.
So we should update this user story to by more generalized to accept multiple correct answers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have switched from Object
and Symbol
to your proposed solution. I've also updated the wording of the stories a bit. Ready for another review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go in
Checklist:
Update index.md
)Closes #469