Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add lab project for CSS grid in frontend cert #480

Merged
merged 17 commits into from
Aug 19, 2024

Conversation

larymak
Copy link
Contributor

@larymak larymak commented Jul 17, 2024

Checklist:

Closes #404

screenshot-127 0 0 1_5500-2024 07 19-10_33_59

@jdwilkin4 jdwilkin4 added full stack cert Labs Team This work is for the labs team only labels Jul 17, 2024
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be shown to campers as an example project that fulfills all the user stories. Do you think you could come up with some fun content to put in this instead of placeholder stuff @larymak? GPT can be really helpful with this. Maybe "Cats Monthly" or something.

@larymak
Copy link
Contributor Author

larymak commented Jul 19, 2024

This will be shown to campers as an example project that fulfills all the user stories. Do you think you could come up with some fun content to put in this instead of placeholder stuff @larymak? GPT can be really helpful with this. Maybe "Cats Monthly" or something.

Done

@larymak larymak requested review from jdwilkin4 and moT01 July 20, 2024 12:14
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @ihechikara 👍

I would be fine getting this in - but I'm wondering if there's any way we can word some of the user stories so that it doesn't give away the answer. For instance, instead of "The .magazine-cover should have a grid-template-columns property of 1fr 1fr 1fr.", maybe "The .magazine-cover should have a grid-template-columns property that divides the space into three equal parts." Similar with the others if possible, specifically the grid stuff - but it doesn't have to be like that either. What do you think?

@larymak
Copy link
Contributor Author

larymak commented Jul 25, 2024

This looks good @ihechikara 👍

I would be fine getting this in - but I'm wondering if there's any way we can word some of the user stories so that it doesn't give away the answer. For instance, instead of "The .magazine-cover should have a grid-template-columns property of 1fr 1fr 1fr.", maybe "The .magazine-cover should have a grid-template-columns property that divides the space into three equal parts." Similar with the others if possible, specifically the grid stuff - but it doesn't have to be like that either. What do you think?

I think it's a good idea. Let me reword the sections that need change

Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some more suggestions...

Instead of using divs, we should use main and section elements to be more semantic?

I also suggested to get rid of a number of the user stories and just include the ones I think are necessary - e.g. just keep the ones that provide a little boilerplate and the ones related to grid. I don't really see the others adding much benefit - it will make the projects easier for users to follow and make it easier for us to write the tests. Let me know what you think @larymak.

frontend-cert/css-projects/css-grid/user-stories.md Outdated Show resolved Hide resolved
frontend-cert/css-projects/css-grid/user-stories.md Outdated Show resolved Hide resolved
@larymak
Copy link
Contributor Author

larymak commented Aug 13, 2024

I have some more suggestions...

Instead of using divs, we should use main and section elements to be more semantic?

I also suggested to get rid of a number of the user stories and just include the ones I think are necessary - e.g. just keep the ones that provide a little boilerplate and the ones related to grid. I don't really see the others adding much benefit - it will make the projects easier for users to follow and make it easier for us to write the tests. Let me know what you think @larymak.

I have updated the user stories as well as the code, let me know what you think

Copy link
Contributor

@Dario-DC Dario-DC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. Once they are resolved I think this can be merged 👍

frontend-cert/css-projects/css-grid/user-stories.md Outdated Show resolved Hide resolved
frontend-cert/css-projects/css-grid/user-stories.md Outdated Show resolved Hide resolved
frontend-cert/css-projects/css-grid/user-stories.md Outdated Show resolved Hide resolved
frontend-cert/css-projects/css-grid/user-stories.md Outdated Show resolved Hide resolved
@moT01 moT01 merged commit a95dc3f into freeCodeCamp:main Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: add lab project for CSS grid in frontend cert
5 participants