-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add lab project for CSS grid in frontend cert #480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be shown to campers as an example project that fulfills all the user stories. Do you think you could come up with some fun content to put in this instead of placeholder stuff @larymak? GPT can be really helpful with this. Maybe "Cats Monthly" or something.
Done |
…Expansion into feat-add-css-grid-lab
…to feat-add-css-grid-lab
…Expansion into feat-add-css-grid-lab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @ihechikara 👍
I would be fine getting this in - but I'm wondering if there's any way we can word some of the user stories so that it doesn't give away the answer. For instance, instead of "The .magazine-cover
should have a grid-template-columns
property of 1fr 1fr 1fr
.", maybe "The .magazine-cover
should have a grid-template-columns
property that divides the space into three equal parts." Similar with the others if possible, specifically the grid stuff - but it doesn't have to be like that either. What do you think?
I think it's a good idea. Let me reword the sections that need change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some more suggestions...
Instead of using divs, we should use main and section elements to be more semantic?
I also suggested to get rid of a number of the user stories and just include the ones I think are necessary - e.g. just keep the ones that provide a little boilerplate and the ones related to grid. I don't really see the others adding much benefit - it will make the projects easier for users to follow and make it easier for us to write the tests. Let me know what you think @larymak.
I have updated the user stories as well as the code, let me know what you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments. Once they are resolved I think this can be merged 👍
Checklist:
Update index.md
)Closes #404