feat(curriculum): add voting system lab #57208
Open
+273
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scope: curriculum
zairahira
added
full stack cert
Dario-DC
reviewed
Nov 19, 2024
...um/challenges/english/25-front-end-development/lab-voting-system/673b567e3ba535dda140d278.md
Outdated
Show resolved
Hide resolved
...um/challenges/english/25-front-end-development/lab-voting-system/673b567e3ba535dda140d278.md
Outdated
Show resolved
Hide resolved
moT01
requested changes
Nov 22, 2024
There was a problem hiding this comment.
This is a lot of fun @zairahira 🎉 I left comments on a few minor typos below. One other issue I has was that the tests were interfering with me testing and debugging my code:
image
They are overwriting the things I add. I think we need to try and fix this. Can we do some reassignment to not overwrite the users polls/votes?
One other thing you could add is some user stories and tests like I mentioned on the bank account lab to have users add to their poll and make votes. e.g.
"You should have at least three options in your poll."
"Your poll should have at least three votes."
Not necessary to add that, but I think it makes it better.
...um/challenges/english/25-front-end-development/lab-voting-system/673b567e3ba535dda140d278.md
Outdated
Show resolved
Hide resolved
...um/challenges/english/25-front-end-development/lab-voting-system/673b567e3ba535dda140d278.md
Outdated
Show resolved
Hide resolved
...um/challenges/english/25-front-end-development/lab-voting-system/673b567e3ba535dda140d278.md
Outdated
Show resolved
Hide resolved
moT01
added
status: waiting update
Co-authored-by: Tom <[email protected]>
Co-authored-by: Tom <[email protected]>
jdwilkin4
added
status: waiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Closes freeCodeCamp/CurriculumExpansion#655