Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): add form validation lab to FSD cert #57211

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(curriculum): add form validation lab to FSD cert #57211

wants to merge 9 commits into from

Conversation

Dario-DC
Copy link
Contributor

@Dario-DC Dario-DC commented Nov 18, 2024 •
edited
Loading

Checklist:

Closes freeCodeCamp/CurriculumExpansion#646

If you want to test this lab with the provided JS solution, be sure to use the HTML from the solution (not from the seed).
There's a clear button in my solution but I decided to not include it in the user stories because the lab is already way too long.

@Dario-DC Dario-DC added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. full stack cert This label is for the new full stack certification labels Nov 18, 2024
@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Nov 18, 2024
@Dario-DC Dario-DC marked this pull request as ready for review November 22, 2024 13:50
@Dario-DC Dario-DC requested a review from a team as a code owner November 22, 2024 13:50
@Dario-DC Dario-DC added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 22, 2024
@Dario-DC
Copy link
Contributor Author

Dario-DC commented Nov 22, 2024 •
edited
Loading

Running the tests locally this one fails:
"When the form is filled correctly and you try to submit it you should set the inner text of #message-box to an empty string."

Not sure why since it seems to work well when I built the client and completed the lab.

Anyway I'm removing it just to see if that is related to this:
image

Edit: SOLVED

@Dario-DC Dario-DC removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 22, 2024
@Dario-DC Dario-DC added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 22, 2024
fhsinchy
fhsinchy approved these changes Nov 29, 2024
View reviewed changes
Copy link

@fhsinchy fhsinchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately couldn't find anything to complain about @Dario-DC 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zairahira zairahira zairahira left review comments

@fhsinchy fhsinchy fhsinchy approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
full stack cert This label is for the new full stack certification platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add form validation lab to main repo
3 participants
@Dario-DC @fhsinchy @zairahira