Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPM causes issues when using multiple project subdirectories #291

Open
mthierman opened this issue Aug 15, 2024 · 2 comments
Open

CPM causes issues when using multiple project subdirectories #291

mthierman opened this issue Aug 15, 2024 · 2 comments

Comments

@mthierman
Copy link
Contributor

CPM seems to populate in the binary directory of the first target added, when it should perhaps go in a more general directory. This seems to be causing that target to ignore DEBUG_POSTFIX, making it more difficult to switch between release & debug builds.

@mthierman
Copy link
Contributor Author

OK, this is caused by how rtaudio and rtmidi CMake is written, combined with our guarantee strategy

They both set DEBUG_POSTFIX
https://github.com/thestk/rtaudio/blob/0cee8ed34dcb10a29416a0cdc4d652c158abd2a2/CMakeLists.txt#L44
https://github.com/thestk/rtmidi/blob/53809fc1869a9789c4631a11081c1840b6db1527/CMakeLists.txt#L35

We don't call guarantee_rtaudio/guarantee_rtmidi so this doesn't apply until after the first target_add_standalone_wrapper call. Therefore, the first target you set up will have different settings.

Will have to ponder the correct solution here for a bit.

@baconpaul
Copy link
Collaborator

ugh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants