Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark public API with the public keyword #19

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Mark public API with the public keyword #19

merged 1 commit into from
Jul 12, 2024

Conversation

fredrikekre
Copy link
Owner

This patch marks the public API of Prometheus.jl with the public keyword in Julia versions that support it.

The public symbols are: CollectorRegistry, register, unregister, Counter, Gauge, Histogram, Summary, GCCollector, ProcessCollector, inc, dec, set, set_to_current_time, observe, @inprogress, @time, Family, labels, remove, clear, and expose.

This patch marks the public API of Prometheus.jl with the `public`
keyword in Julia versions that support it.

The public symbols are: `CollectorRegistry`, `register`, `unregister`,
`Counter`, `Gauge`, `Histogram`, `Summary`, `GCCollector`,
`ProcessCollector`, `inc`, `dec`, `set`, `set_to_current_time`,
`observe`, `@inprogress`, `@time`, `Family`, `labels`, `remove`,
`clear`, and `expose`.
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (f58bcca) to head (bc26123).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files           3        3           
  Lines         470      470           
=======================================
  Hits          459      459           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredrikekre fredrikekre merged commit 0a2e4ea into master Jul 12, 2024
11 checks passed
@fredrikekre fredrikekre deleted the fe/public branch July 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant