ProcessCollector: initialize on first use #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes how the ProcessCollector is initialized. Previously some values where read from /proc filesystem in the constructor but since typically a collector is defined as a global variable this results in values beeing cached from precompilation. With this patch the collector is initialized on first use (first `Prometheus.collect!`) instead.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
==========================================
+ Coverage 97.59% 97.65% +0.06%
==========================================
Files 3 3
Lines 457 470 +13
==========================================
+ Hits 446 459 +13
Misses 11 11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes how the ProcessCollector is initialized. Previously some values where read from /proc filesystem in the constructor but since typically a collector is defined as a global variable this results in values beeing cached from precompilation. With this patch the collector is initialized on first use (first
Prometheus.collect!) instead.