Payroll Entry : Make Bank Entry

[thida-bcn]

Information about bug

App Versions

{
	"bcn_hrms": "0.0.1",
	"erpnext": "15.29.2",
	"frappe": "15.33.3",
	"hrms": "15.23.1",
	"lending": "0.0.1"
}

Route

Form/Payroll Entry/HR-PRUN-2024-00001

Traceback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 114, in application
    response = frappe.api.handle(request)
  File "apps/frappe/frappe/api/__init__.py", line 49, in handle
    data = endpoint(**arguments)
  File "apps/frappe/frappe/api/v1.py", line 36, in handle_rpc_call
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 49, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1768, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/handler.py", line 330, in run_doc_method
    response = doc.run_method(method)
  File "apps/frappe/frappe/model/document.py", line 962, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1322, in composer
    return composed(self, method, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1304, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "apps/frappe/frappe/model/document.py", line 959, in fn
    return method_object(*args, **kwargs)
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
  File "apps/hrms/hrms/payroll/doctype/payroll_entry/payroll_entry.py", line 886, in make_bank_entry
    self.set_accounting_entries_for_bank_entry(salary_slip_total, "salary")
  File "apps/hrms/hrms/payroll/doctype/payroll_entry/payroll_entry.py", line 985, in set_accounting_entries_for_bank_entry
    self.make_journal_entry(
  File "apps/hrms/hrms/payroll/doctype/payroll_entry/payroll_entry.py", line 610, in make_journal_entry
    journal_entry.save(ignore_permissions=True)
  File "apps/frappe/frappe/model/document.py", line 337, in save
    return self._save(*args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 359, in _save
    return self.insert()
  File "apps/frappe/frappe/model/document.py", line 291, in insert
    self.run_before_save_methods()
  File "apps/frappe/frappe/model/document.py", line 1091, in run_before_save_methods
    self.run_method("validate")
  File "apps/frappe/frappe/model/document.py", line 962, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1322, in composer
    return composed(self, method, *args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 1304, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "apps/frappe/frappe/model/document.py", line 959, in fn
    return method_object(*args, **kwargs)
  File "apps/erpnext/erpnext/accounts/doctype/journal_entry/journal_entry.py", line 142, in validate
    self.set_against_account()
  File "apps/erpnext/erpnext/accounts/doctype/journal_entry/journal_entry.py", line 855, in set_against_account
    d.against_account = ", ".join(list(set(accounts_credited)))
TypeError: sequence item 0: expected str instance, NoneType found

Request Data

{
	"type": "POST",
	"args": {
		"method": "make_bank_entry",
		"dt": "Payroll Entry",
		"dn": "HR-PRUN-2024-00001"
	},
	"freeze": true,
	"freeze_message": "Creating Payment Entries......",
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/run_doc_method",
	"request_id": null
}

Response Data

{
	"exception": "TypeError: sequence item 0: expected str instance, NoneType found",
	"exc_type": "TypeError",
	"_exc_source": "hrms (app)"
}

when user click make bank entry without choosing Payment Account

Module

HR

Version

"erpnext": "15.29.2",
"frappe": "15.33.3",
"hrms": "15.23.1",
"lending": "0.0.1"

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

No response

Code of Conduct

• I agree to follow this project's Code of Conduct