-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text-Editor, External and Internal Link handling #3903
Comments
Good idea, will add some support for adding custom attributes to link and image |
I've been thinking about how to make the feature nice to use from a user perspective. The calendar gets a additional property. These property contains filters. With the filters Framework7 finds out what are internal links and what are external links. If a url starts with "https://framework7.io/" then it is an internal link. Everything else is an external link. Maybe you can also work with regex here. This would have the great advantage that the logic is not in the editor content. |
Ok, so not to mess with formats, I think it is better to leave it to developer to decide. So now (with next release), editor will have |
This is the best solution. 👍 |
Hi,
I use the Text Editor more and more often.
This one works great overall.
I hope I have not overlooked the following feature so far.
An optimization is what I would like to see.
When using a link, I often miss the option, if the link is an internal link for Framwork7 or an external link.
External links should not run through the router.
In Framework7 is used for the component Link the class "external" for it in combination with _blank, _self
The feature could be used like this.
Linkinput
{external:_blank}https://framework7.io/svelte/link.html
With the first part you can add the Framwork7 classen and attributes for the link.
Only as a suggestion.
The text was updated successfully, but these errors were encountered: