feat: ✨ made initial content container invisible for errors as well

Author: arctic-hen7

examples/basic/.perseus/src/lib.rs

@@ -93,6 +93,8 @@ pub fn run() -> Result<(), JsValue> {
                                         let initial_html = initial_container.inner_html();
                                         container_rx_elem.set_inner_html(&initial_html);
                                         initial_container.set_inner_html("");
+                                        // Make the initial container invisible
+                                        initial_container.set_attribute("style", "display: none;").unwrap();
                                         // Hydrate the error pages
                                         // Right now, we don't provide translators to any error pages that have come from the server
                                         error_pages.hydrate_page(&url, &status, &err, None, &container_rx_elem);

packages/perseus/src/shell.rs

@@ -229,7 +229,9 @@ pub async fn app_shell(
             container_rx_elem.set_inner_html(&initial_html);
             initial_container.set_inner_html("");
             // Make the initial container invisible
-            initial_container.set_attribute("style", "display: none;").unwrap();
+            initial_container
+                .set_attribute("style", "display: none;")
+                .unwrap();
             checkpoint("page_visible");
             // Now that the user can see something, we can get the translator
             let mut translations_manager_mut = translations_manager.borrow_mut();
@@ -379,6 +381,10 @@ pub async fn app_shell(
             let initial_html = initial_container.inner_html();
             container_rx_elem.set_inner_html(&initial_html);
             initial_container.set_inner_html("");
+            // Make the initial container invisible
+            initial_container
+                .set_attribute("style", "display: none;")
+                .unwrap();
             // Hydrate the currently static error page
             // Right now, we don't provide translators to any error pages that have come from the server
             error_pages.hydrate_page(&url, &status, &err, None, &container_rx_elem);