Explicitly link ntdll when building test-gfx on Windows

[Kryptos-FR]

Following changes introduced by rust-lang/rust#108262

[codecov]

Codecov Report

Merging #642 (03372a3) into devel (0dd4f8d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel     #642      +/-   ##
==========================================
- Coverage   80.78%   80.77%   -0.02%     
==========================================
  Files         258      258              
  Lines       32015    32015              
==========================================
- Hits        25863    25859       -4     
- Misses       6152     6156       +4     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sinkingsugar]

Not happy, rust should fix it, ntdll is not meant to be used directly as it's a private library...

[sinkingsugar]

wow they really did it, just saw the PR.. super weird... btw it's only for GNU toolchain. so we should at least respect that.

[Kryptos-FR]

wow they really did it, just saw the PR.. super weird... btw it's only for GNU toolchain. so we should at least respect that.

No it's actually only failing for MSVC. They made it available for gnu and as a side-effect made MSVC fail in our case. Not sure why it only occurs for test-gfx but it looks like it was already included in other places when we build shards libraries.

For instance, we manually add it here:

• https://github.com/fragcolor-xyz/shards/blob/devel/src/extra/CMakeLists.txt#L57
• https://github.com/fragcolor-xyz/shards/blob/devel/rust/CMakeLists.txt#L35

According to the PR, it is needed with both targets:

• MSVC: https://github.com/rust-lang/rust/pull/108262/files#diff-6836f9aedd812ef2e3166774f01ad33c5c05582c13ca5ff7e6f16e3556af4dceR115
• GNU: https://github.com/rust-lang/rust/pull/108262/files#diff-6836f9aedd812ef2e3166774f01ad33c5c05582c13ca5ff7e6f16e3556af4dceR117