Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fractal-server v2.7] Display warnings in workflow page #578

Open
tcompa opened this issue Oct 7, 2024 · 2 comments
Open

[fractal-server v2.7] Display warnings in workflow page #578

tcompa opened this issue Oct 7, 2024 · 2 comments

Comments

@tcompa
Copy link
Collaborator

tcompa commented Oct 7, 2024

As of fractal-server 2.7.0, the response of GET /api/v2/project/{id}/workflow/{id}/ includes additional information.

Now each item in response.task_list has an optional string property warning, which is pre-populated server-side and typically may be one of these:

  • "Task is not active."
  • "Current user has no access to this task."

When this warning property is set, we should display it in the task list in the workflow page.
Note that these warnings are blocking: if we try to submit a job which include one these tasks, submission will fail with a 422. If we display the information in advance, it will be more clear for the user.

@zonia3000
Copy link
Collaborator

I noticed that the endpoint PATCH /api/v2/project/{id}/workflow/{id}/ doesn't return the warning property. Is this expected? Could it be possible to add this property also on that endpoint?

Currently, when the PATCH is called to change the tasks order, the code replaces the displayed tasks list with the patched one and the warning would disappear.

@zonia3000
Copy link
Collaborator

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants