Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search box to "insert task" modal #238

Closed
rkpasia opened this issue Jul 4, 2023 · 5 comments · Fixed by #386
Closed

Add search box to "insert task" modal #238

rkpasia opened this issue Jul 4, 2023 · 5 comments · Fixed by #386
Labels
feature Feature description issues

Comments

@rkpasia
Copy link
Contributor

rkpasia commented Jul 4, 2023

This bug has been identified while working on #149.
Slim-Select search box feature is conflicting with focusin event of bootstrap event-handler.js

Unfortunately the search box within the dropdown select menu of slim-select has focusin event prevented because it seems to be intercepted by the modal component of bootstrap.

I can't figure out a solution on this matter right now.

@rkpasia rkpasia added the bug Something isn't working label Jul 4, 2023
@jluethi
Copy link
Collaborator

jluethi commented Jul 4, 2023

Ok, too bad. Then will add a search feature later on :)

@rkpasia
Copy link
Contributor Author

rkpasia commented Jul 4, 2023

More on this:

Removing the .modal-dialog div element from within the .modal div container seem to enable the editing of input element of search box managed by slim-select.

Unfortunately, removing the .modal-dialog element prevents the closing feature of the dialog itself. This results in a dialog which is not possibile to be dismissed.
Dismissing the modal is not even possible through a programmatic event via javascript's bootstrap apis.

@tcompa tcompa changed the title Slim-Select search box feature is conflicting with focusin event of bootstrap event-handler.js Add search box to "insert task" modal Jul 5, 2023
@tcompa tcompa added feature Feature description issues and removed bug Something isn't working labels Jul 5, 2023
@jluethi
Copy link
Collaborator

jluethi commented Dec 20, 2023

With the new task modal of common vs. user-specific tasks: It would be best if the search can find task in either.
One idea: A third tab for task search that searches all of them?

@zonia3000 zonia3000 mentioned this issue Jan 9, 2024
1 task
@zonia3000
Copy link
Collaborator

As reported in brianvoe/slim-select#475 (comment), the incompatibility with bootstrap modal can be fixed adding data-bs-focus="false" to the modal, so we are currently using the slim-select search inside task selection:

image

@jluethi
Copy link
Collaborator

jluethi commented Jan 9, 2024

Oh, looks very promising, will have to test this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature description issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants