Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support in-memory cache online resize #794

Merged
merged 2 commits into from
Nov 25, 2024
Merged

feat: support in-memory cache online resize #794

merged 2 commits into from
Nov 25, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Nov 25, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Changes:

  • Support online in-memory cache resize, add unit tests.
  • Fix ModRandomState.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #691

@MrCroxx MrCroxx added the feature New feature or request label Nov 25, 2024
@MrCroxx MrCroxx added this to the v0.13 milestone Nov 25, 2024
@MrCroxx MrCroxx self-assigned this Nov 25, 2024
Signed-off-by: MrCroxx <[email protected]>
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 66.28352% with 88 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-common/src/hasher.rs 41.17% 30 Missing ⚠️
foyer-memory/src/eviction/lfu.rs 28.12% 23 Missing ⚠️
foyer-memory/src/error.rs 0.00% 13 Missing ⚠️
foyer-memory/src/eviction/lru.rs 47.05% 9 Missing ⚠️
foyer-memory/src/eviction/s3fifo.rs 61.90% 8 Missing ⚠️
foyer-memory/src/raw.rs 96.42% 4 Missing ⚠️
foyer-memory/src/cache.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-memory/src/eviction/fifo.rs 92.13% <100.00%> (+1.33%) ⬆️
foyer-memory/src/eviction/mod.rs 100.00% <ø> (ø)
foyer-storage/src/small/generic.rs 76.59% <100.00%> (+0.37%) ⬆️
foyer-storage/src/test_utils.rs 87.75% <ø> (-2.25%) ⬇️
foyer-memory/src/cache.rs 79.23% <0.00%> (-0.19%) ⬇️
foyer-memory/src/raw.rs 92.10% <96.42%> (+1.00%) ⬆️
foyer-memory/src/eviction/s3fifo.rs 91.41% <61.90%> (+2.64%) ⬆️
foyer-memory/src/eviction/lru.rs 92.75% <47.05%> (+1.11%) ⬆️
foyer-memory/src/error.rs 0.00% <0.00%> (ø)
foyer-memory/src/eviction/lfu.rs 85.09% <28.12%> (-0.32%) ⬇️
... and 1 more

🚨 Try these New Features:

@MrCroxx MrCroxx merged commit e0dc273 into main Nov 25, 2024
23 checks passed
@MrCroxx MrCroxx deleted the xx/resize-mem branch November 25, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: online in-memory cache size scaling
1 participant