Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl destroy for sodc #744

Merged
merged 3 commits into from
Sep 27, 2024
Merged

feat: impl destroy for sodc #744

merged 3 commits into from
Sep 27, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Sep 27, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

Changes:

  • Use set 0 as meta set.
  • Use watermark in metaset for destroy.
  • sodc must start from region 0

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#596

Changes:

- Use set 0 as meta set.
- Use watermark in metaset for destroy.
- sodc must start from region 0

Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx added feature New feature or request refactor labels Sep 27, 2024
@MrCroxx MrCroxx added this to the v0.12 milestone Sep 27, 2024
@MrCroxx MrCroxx self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-storage/src/small/generic.rs 93.75% 4 Missing ⚠️
foyer-storage/src/small/set_manager.rs 97.05% 2 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/small/batch.rs 81.33% <100.00%> (+6.66%) ⬆️
foyer-storage/src/small/set.rs 93.61% <100.00%> (+0.12%) ⬆️
foyer-storage/src/small/set_manager.rs 88.32% <97.05%> (+4.11%) ⬆️
foyer-storage/src/small/generic.rs 74.87% <93.75%> (+14.57%) ⬆️

... and 2 files with indirect coverage changes

@MrCroxx MrCroxx merged commit fa8f011 into main Sep 27, 2024
22 checks passed
@MrCroxx MrCroxx deleted the xx/small-destroy branch September 27, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant